Skip to content

[Hub Menu] Make View Store button pink #8597

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

[Hub Menu] Make View Store button pink #8597

wants to merge 1 commit into from

Conversation

@rachelmcr
Copy link
Contributor

@rachelmcr rachelmcr commented Jan 9, 2023 •
edited
Loading

Closes: ##8592

Description

One side effect of the color updates in #8451 was to change the "View Store" button from pink to purple (same color as the Reviews button). This PR changes that button back to pink, so the Hub Menu buttons remain differentiated by color.

Note: This PR is currently in draft status pending design approval (internal ref: p1673286868466219-slack-C0354HSNUJH)

Testing instructions

  1. Build and run the app.
  2. Open the Menu tab.
  3. Confirm the "View Store" button is now pink (different color from the other buttons).

Screenshots

Before After
Simulator Screen Shot - iPhone 14 Pro - 2023-01-09 at 17 50 37 Simulator Screen Shot - iPhone 14 Pro - 2023-01-09 at 17 38 57
Simulator Screen Shot - iPhone 14 Pro - 2023-01-09 at 17 50 41 Simulator Screen Shot - iPhone 14 Pro - 2023-01-09 at 17 39 18
  • I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

@rachelmcr rachelmcr added category: design Layout and style elements in the UI or user interface, including color and animations. feature: hub menu Related to the Hub Menu tab. labels Jan 9, 2023
@rachelmcr rachelmcr added this to the 11.9 milestone Jan 9, 2023
@wpmobilebot
Copy link
Collaborator

wpmobilebot commented Jan 9, 2023

You can test the changes from this Pull Request by:
  • Clicking here or scanning the QR code below to access App Center
  • Then installing the build number pr8597-831a5ab on your iPhone

If you need access to App Center, please ask a maintainer to add you.

@rachelmcr
Copy link
Contributor Author

rachelmcr commented Jan 10, 2023

Per design feedback (internal ref: p1673286868466219-slack-C0354HSNUJH) we'll leave this button purple for now.

@rachelmcr rachelmcr closed this Jan 10, 2023
@rachelmcr rachelmcr deleted the issue/8592-hub-menu-button-colors branch February 20, 2023 12:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

category: design Layout and style elements in the UI or user interface, including color and animations. feature: hub menu Related to the Hub Menu tab.

Projects

None yet

Milestone

11.9

Development

Successfully merging this pull request may close these issues.

3 participants

@rachelmcr @wpmobilebot